From 25b9a530b3b19b9dcb27b9596df51f43bb272bd8 Mon Sep 17 00:00:00 2001
From: iximeow <me@iximeow.net>
Date: Sun, 23 Jun 2024 22:22:31 -0700
Subject: fix several sources of dead code warnings in various crate configs

---
 src/protected_mode/display.rs | 6 +++---
 src/protected_mode/mod.rs     | 9 ++++++---
 2 files changed, 9 insertions(+), 6 deletions(-)

(limited to 'src/protected_mode')

diff --git a/src/protected_mode/display.rs b/src/protected_mode/display.rs
index 6c63f46..dc31dbf 100644
--- a/src/protected_mode/display.rs
+++ b/src/protected_mode/display.rs
@@ -5,7 +5,7 @@ use core::fmt;
 use yaxpeax_arch::{Colorize, ShowContextual, NoColors, YaxColors};
 
 use crate::MEM_SIZE_STRINGS;
-use crate::protected_mode::{RegSpec, Opcode, Operand, MergeMode, InstDecoder, Instruction, Segment, PrefixVex, OperandSpec};
+use crate::protected_mode::{RegSpec, Opcode, Operand, MergeMode, InstDecoder, Instruction, Segment, PrefixVex};
 
 use yaxpeax_arch::display::DisplaySink;
 use yaxpeax_arch::safer_unchecked::GetSaferUnchecked as _;
@@ -2758,7 +2758,7 @@ impl <T: fmt::Write, Y: YaxColors> ShowContextual<u64, [Option<alloc::string::St
             Some(s) => { write!(out, " {}", s)?; },
             None => {
                 match self.operands[0] {
-                    OperandSpec::Nothing => {
+                    super::OperandSpec::Nothing => {
                         return Ok(());
                     },
                     _ => {
@@ -2778,7 +2778,7 @@ impl <T: fmt::Write, Y: YaxColors> ShowContextual<u64, [Option<alloc::string::St
                 Some(s) => { write!(out, ", {}", s)? }
                 None => {
                     match &self.operands[i] {
-                        &OperandSpec::Nothing => {
+                        &super::OperandSpec::Nothing => {
                             return Ok(());
                         },
                         _ => {
diff --git a/src/protected_mode/mod.rs b/src/protected_mode/mod.rs
index b02079e..956b5e3 100644
--- a/src/protected_mode/mod.rs
+++ b/src/protected_mode/mod.rs
@@ -741,7 +741,8 @@ impl Operand {
 
     /// provided for parity with [`Instruction::visit_operand`]. this has little utility other than
     /// to reuse an `OperandVisitor` on an `Operand` directly.
-    pub fn visit<T: OperandVisitor>(&self, visitor: &mut T) -> Result<T::Ok, T::Error> {
+    #[allow(dead_code)] // in some configurations this is unused, but it is internal-only for now, so it would warn.
+    fn visit<T: OperandVisitor>(&self, visitor: &mut T) -> Result<T::Ok, T::Error> {
         match self {
             Operand::Nothing => {
                 visitor.visit_other()
@@ -4309,6 +4310,7 @@ impl Opcode {
     }
 
     #[inline(always)]
+    #[allow(dead_code)] // in some configurations this is unused, but it is internal-only for now, so it would warn.
     fn can_rep(&self) -> bool {
         (*self as u32) & 0x2000 != 0
     }
@@ -4334,7 +4336,8 @@ impl Instruction {
         Operand::from_spec(self, self.operands[i as usize])
     }
 
-    /// TODO: make public, document, etc...
+    // TODO: make public when this seems stable and worthwhile. currently only used for display
+    // and Displaysink etc..
     ///
     /// `visit_operand` allows code using operands to better specialize and inline with the logic
     /// that would construct an [`Operand`] variant, without having to necessarily construct an
@@ -4344,8 +4347,8 @@ impl Instruction {
     /// dispatching on tags may be a substantial factor of overall runtime. `visit_operand` can
     /// reduce total overhead in such cases.
     #[cfg_attr(feature="profiling", inline(never))]
+    #[allow(dead_code)] // in some configurations this is unused, but it is internal-only for now, so it would warn.
     fn visit_operand<T: OperandVisitor>(&self, i: u8, visitor: &mut T) -> Result<T::Ok, T::Error> {
-        assert!(i < 4);
         let spec = self.operands[i as usize];
         match spec {
             OperandSpec::Nothing => {
-- 
cgit v1.1