From 3291884e4c51cfd93ae0f84681c5dd00e2e8544d Mon Sep 17 00:00:00 2001
From: iximeow <me@iximeow.net>
Date: Tue, 2 Apr 2024 00:54:58 -0700
Subject: display: gate rep printing with a simpler check

testing against six opcodes to see if we should print rep or repnz is a
bit absurd. they are relatively rare instructions, so this is a long
sequence of never-taken tests. we can avoid the whole thing in the
common case by testing if there is any kind of rep prefix at all.
---
 src/long_mode/display.rs | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/long_mode/display.rs b/src/long_mode/display.rs
index c1c6c65..1a31073 100644
--- a/src/long_mode/display.rs
+++ b/src/long_mode/display.rs
@@ -3862,12 +3862,14 @@ impl <T: fmt::Write, Y: YaxColors> ShowContextual<u64, [Option<alloc::string::St
             write!(out, "lock ")?;
         }
 
-        if [Opcode::MOVS, Opcode::CMPS, Opcode::LODS, Opcode::STOS, Opcode::INS, Opcode::OUTS].contains(&self.opcode) {
-            // only a few of you actually use the prefix...
-            if self.prefixes.rep() {
-                write!(out, "rep ")?;
-            } else if self.prefixes.repnz() {
-                write!(out, "repnz ")?;
+        if self.prefixes.rep_any() {
+            if [Opcode::MOVS, Opcode::CMPS, Opcode::LODS, Opcode::STOS, Opcode::INS, Opcode::OUTS].contains(&self.opcode) {
+                // only a few of you actually use the prefix...
+                if self.prefixes.rep() {
+                    write!(out, "rep ")?;
+                } else if self.prefixes.repnz() {
+                    write!(out, "repnz ")?;
+                }
             }
         }
 
-- 
cgit v1.1