From 2097524c851b15e89091fd3775817a06f0eeae4f Mon Sep 17 00:00:00 2001
From: iximeow <me@iximeow.net>
Date: Sun, 24 Apr 2022 17:39:21 -0700
Subject: fix a few issues preventing no-std builds from ... building

this includes a `Makefile` that exercises the various crate configs.
most annoyingly, several doc comments needed to grow
`#[cfg(feature="fmt")]` blocks so docs continue to build with that
feature enabled or disabled.

carved out a way to run exhaustive tests; they should be written as
`#[ignore]`, and then the makefile will run even ignored tests on the
expectation that this will run the exhaustive (but slower) suite.
exhaustive tests are not yet written. they'll probably involve spanning
4 byte sequences from 0 to 2^32-1.
---
 test/protected_mode/mod.rs | 49 ++++++++++++++++++++++++++++++++++------------
 1 file changed, 37 insertions(+), 12 deletions(-)

(limited to 'test/protected_mode/mod.rs')

diff --git a/test/protected_mode/mod.rs b/test/protected_mode/mod.rs
index 744d006..9cda6be 100644
--- a/test/protected_mode/mod.rs
+++ b/test/protected_mode/mod.rs
@@ -1,5 +1,6 @@
 mod regspec;
 mod operand;
+#[cfg(feature="fmt")]
 mod display;
 mod evex_generated;
 
@@ -15,7 +16,17 @@ fn test_invalid(data: &[u8]) {
 fn test_invalid_under(decoder: &InstDecoder, data: &[u8]) {
     let mut reader = yaxpeax_arch::U8Reader::new(data);
     if let Ok(inst) = decoder.decode(&mut reader) {
-        panic!("decoded {:?} from {:02x?} under decoder {}", inst.opcode(), data, decoder);
+        // realistically, the chances an error only shows up under non-fmt builds seems unlikely,
+        // but try to report *something* in such cases.
+        cfg_if::cfg_if! {
+            if #[cfg(feature="fmt")] {
+                panic!("decoded {:?} from {:02x?} under decoder {}", inst.opcode(), data, decoder);
+            } else {
+                // don't warn about the unused inst here
+                let _ = inst;
+                panic!("decoded instruction <non-fmt build> from {:02x?} under decoder <non-fmt build>", data);
+            }
+        }
     } else {
         // this is fine
     }
@@ -33,22 +44,36 @@ fn test_display_under(decoder: &InstDecoder, data: &[u8], expected: &'static str
     let mut reader = yaxpeax_arch::U8Reader::new(data);
     match decoder.decode(&mut reader) {
         Ok(instr) => {
-            let text = format!("{}", instr);
-            assert!(
-                text == expected,
-                "display error for {}:\n  decoded: {:?} under decoder {}\n displayed: {}\n expected: {}\n",
-                hex,
-                instr,
-                decoder,
-                text,
-                expected
-            );
+            cfg_if::cfg_if! {
+                if #[cfg(feature="fmt")] {
+                    let text = format!("{}", instr);
+                    assert!(
+                        text == expected,
+                        "display error for {}:\n  decoded: {:?} under decoder {}\n displayed: {}\n expected: {}\n",
+                        hex,
+                        instr,
+                        decoder,
+                        text,
+                        expected
+                    );
+                } else {
+                    eprintln!("non-fmt build cannot compare text equality")
+                }
+            }
             // while we're at it, test that the instruction is as long, and no longer, than its
             // input
             assert_eq!((0u32.wrapping_offset(instr.len()).to_linear()) as usize, data.len(), "instruction length is incorrect, wanted instruction {}", expected);
         },
         Err(e) => {
-            assert!(false, "decode error ({}) for {} under decoder {}:\n  expected: {}\n", e, hex, decoder, expected);
+            cfg_if::cfg_if! {
+                if #[cfg(feature="fmt")] {
+                    assert!(false, "decode error ({}) for {} under decoder {}:\n  expected: {}\n", e, hex, decoder, expected);
+                } else {
+                    // avoid the unused `e` warning
+                    let _ = e;
+                    assert!(false, "decode error (<non-fmt build>) for {} under decoder <non-fmt build>:\n  expected: {}\n", hex, expected);
+                }
+            }
         }
     }
 }
-- 
cgit v1.1