aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/armv7.rs15
-rw-r--r--src/armv7/thumb.rs54
2 files changed, 52 insertions, 17 deletions
diff --git a/src/armv7.rs b/src/armv7.rs
index d98cfb0..bd4629e 100644
--- a/src/armv7.rs
+++ b/src/armv7.rs
@@ -94,14 +94,18 @@ impl <T: fmt::Write, Color: fmt::Display, Y: YaxColors<Color>> ShowContextual<u3
}
Opcode::CPS(_) => {
if let Operand::Imm12(aif) = &self.operands[0] {
- return write!(
+ write!(
out,
"{} {}{}{}",
&self.opcode,
if aif & 0b100 != 0 { "a" } else { "" },
if aif & 0b010 != 0 { "i" } else { "" },
if aif & 0b001 != 0 { "f" } else { "" },
- );
+ )?;
+ if let Operand::Imm12(mode) = &self.operands[1] {
+ write!(out, ", #{:x}", mode)?;
+ }
+ return Ok(());
} else {
panic!("impossible cps operand");
}
@@ -136,7 +140,7 @@ impl <T: fmt::Write, Color: fmt::Display, Y: YaxColors<Color>> ShowContextual<u3
Opcode::LDM(true, false, false, _usermode) => {
// TODO: what indicates usermode in the ARM syntax?
match self.operands {
- [Operand::RegWBack(Reg { bits: 13 }, wback), Operand::RegList(list), Operand::Nothing, Operand::Nothing] => {
+ [Operand::RegWBack(Reg { bits: 13 }, true), Operand::RegList(list), Operand::Nothing, Operand::Nothing] => {
ConditionedOpcode(Opcode::POP, self.s(), self.w(), self.condition).colorize(colors, out)?;
write!(out, " ")?;
return format_reg_list(out, list, colors);
@@ -147,7 +151,7 @@ impl <T: fmt::Write, Color: fmt::Display, Y: YaxColors<Color>> ShowContextual<u3
Opcode::STM(false, true, false, _usermode) => {
// TODO: what indicates usermode in the ARM syntax?
match self.operands {
- [Operand::RegWBack(Reg { bits: 13 }, wback), Operand::RegList(list), Operand::Nothing, Operand::Nothing] => {
+ [Operand::RegWBack(Reg { bits: 13 }, true), Operand::RegList(list), Operand::Nothing, Operand::Nothing] => {
ConditionedOpcode(Opcode::PUSH, self.s(), self.w(), self.condition).colorize(colors, out)?;
write!(out, " ")?;
return format_reg_list(out, list, colors);
@@ -575,6 +579,7 @@ impl <T: fmt::Write, Color: fmt::Display, Y: YaxColors<Color>> Colorize<T, Color
Opcode::DBG |
Opcode::CPS(_) |
+ Opcode::CPS_modeonly |
Opcode::SETEND |
Opcode::ENTERX |
Opcode::LEAVEX |
@@ -782,6 +787,7 @@ impl Display for Opcode {
Opcode::CBNZ => { write!(f, "cbnz") },
Opcode::SETEND => { write!(f, "setend") },
Opcode::CPS(disable) => { write!(f, "cps{}", if *disable { "id" } else { "ie" }) },
+ Opcode::CPS_modeonly => { write!(f, "cps") },
Opcode::REV => { write!(f, "rev") },
Opcode::REV16 => { write!(f, "rev16") },
Opcode::REVSH => { write!(f, "revsh") },
@@ -987,6 +993,7 @@ pub enum Opcode {
CBNZ,
SETEND,
CPS(bool),
+ CPS_modeonly,
REV,
REV16,
REVSH,
diff --git a/src/armv7/thumb.rs b/src/armv7/thumb.rs
index ab28be8..ecbf119 100644
--- a/src/armv7/thumb.rs
+++ b/src/armv7/thumb.rs
@@ -1591,14 +1591,42 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
if op1 != 0b000 {
// `CPS (Thumb)` (`B9-1964`)
// v6T2
- let _mode = lower & 0b11111;
- let _aif = (lower >> 5) & 0b111;
- let _m = (lower >> 8) & 1;
- let _imod = (lower >> 9) & 0b11;
- // TODO: no CPS instruction? yet?
- eprintln!("cps support is not complete");
- return Err(DecodeError::Incomplete);
- // inst.opcode = Opcode::CPS;
+ // encoding T2
+ let mode = lower2[0..5].load::<u16>();
+ let m = lower2[8];
+ let aif = lower2[5..8].load::<u16>();
+ let imod = lower2[9..11].load::<u8>();
+
+ if !m && imod == 0b00 {
+ // unreachable; would be a hint
+ }
+ if !m && mode != 0 {
+ decoder.unpredictable()?;
+ }
+ if imod < 0b10 {
+ if imod == 0b01 {
+ decoder.unpredictable()?;
+ }
+ inst.opcode = Opcode::CPS_modeonly;
+ inst.operands = [
+ Operand::Imm12(mode),
+ Operand::Nothing,
+ Operand::Nothing,
+ Operand::Nothing,
+ ];
+ } else {
+ inst.opcode = Opcode::CPS(imod == 0b11);
+ inst.operands = [
+ Operand::Imm12(aif),
+ if m {
+ Operand::Imm12(mode)
+ } else {
+ Operand::Nothing
+ },
+ Operand::Nothing,
+ Operand::Nothing,
+ ];
+ }
} else {
if op2 >= 0b11110000 {
// `DBG` (`A8-378`)
@@ -2385,7 +2413,7 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
inst.opcode = opcode;
inst.operands = [
Operand::Reg(Reg::from_u8(rt)),
- Operand::RegDerefPreindexOffset(Reg::from_u8(rn), imm12, false, false), // no add, no wback
+ Operand::RegDerefPreindexOffset(Reg::from_u8(rn), imm12, u, false), // no add, no wback
Operand::Nothing,
Operand::Nothing,
];
@@ -2557,7 +2585,7 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
inst.opcode = opcode;
inst.operands = [
Operand::Reg(Reg::from_u8(rt)),
- Operand::RegDerefPreindexOffset(Reg::from_u8(rn), imm12, true, false), // add, no wback
+ Operand::RegDerefPreindexOffset(Reg::from_u8(rn), imm12, u, false), // add, no wback
Operand::Nothing,
Operand::Nothing,
];
@@ -2631,7 +2659,7 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
inst.opcode = opcode;
inst.operands = [
Operand::Reg(Reg::from_u8(rt)),
- Operand::RegDerefPreindexOffset(Reg::from_u8(15), imm12, false, false), // add, no wback
+ Operand::RegDerefPreindexOffset(Reg::from_u8(15), imm12, u, false), // add, no wback
Operand::Nothing,
Operand::Nothing,
];
@@ -2842,7 +2870,7 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
][op1];
let rm = lower2[..4].load::<u8>();
- let rotate = lower2[1..3].load::<u8>() << 2;;
+ let rotate = lower2[1..3].load::<u8>() << 2;
let rd = lower2[8..12].load::<u8>();
inst.opcode = op;
@@ -2863,7 +2891,7 @@ pub fn decode_into<T: IntoIterator<Item=u8>>(decoder: &InstDecoder, inst: &mut I
][op1];
let rm = lower2[..4].load::<u8>();
- let rotate = lower2[1..3].load::<u8>() << 2;;
+ let rotate = lower2[1..3].load::<u8>() << 2;
let rd = lower2[8..12].load::<u8>();
inst.opcode = op;
generated by cgit v1.1 at 2024-11-01 05:22:34 +0000