diff options
| author | iximeow <me@iximeow.net> | 2021-08-22 10:46:32 -0700 |
|---|---|---|
| committer | iximeow <me@iximeow.net> | 2021-08-22 10:46:32 -0700 |
| commit | 188cf391845a7d86466cd2ad35459b6bf825bb1e (patch) | |
| tree | 82eb9bc7e76841691d2350c3d1e1772e3afa8a55 /src/protected_mode/mod.rs | |
| parent | 39eef01e04e478ec5cfa3c8f520c831631ecd67d (diff) | |
add 16/32-bit opcode/operand boundary desc, consistentify memory descriptions
Diffstat (limited to 'src/protected_mode/mod.rs')
| -rw-r--r-- | src/protected_mode/mod.rs | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/src/protected_mode/mod.rs b/src/protected_mode/mod.rs index 422f6d9..10a9248 100644 --- a/src/protected_mode/mod.rs +++ b/src/protected_mode/mod.rs @@ -5902,7 +5902,7 @@ fn read_M_16bit< sink.record( modrm_start + 6, modrm_start + 7, - InnerDescription::Misc("mmm selects a dereference with no displacement (mod bits: 00)") + InnerDescription::Misc("memory operand is [reg(s)] with no displacement, register(s) selected by `mmm` (mod bits: 00)") .with_id(modrm_start + 0) ); if mmm > 3 { @@ -5918,7 +5918,7 @@ fn read_M_16bit< sink.record( modrm_start + 6, modrm_start + 7, - InnerDescription::Misc("mmm selects registers for deref address with 8-bit displacement (mod bits: 01)") + InnerDescription::Misc("memory operand is [reg(s)+disp8] indexed by register(s) selected by `mmm` (mod bits: 01)") .with_id(modrm_start + 0) ); sink.record( @@ -5948,7 +5948,7 @@ fn read_M_16bit< sink.record( modrm_start + 6, modrm_start + 7, - InnerDescription::Misc("mmm selects registers for deref address with 16-bit displacement (mod bits: 10)") + InnerDescription::Misc("memory operand is [reg(s)+disp16] indexed by register(s) selected by `mmm` (mod bits: 01)") .with_id(modrm_start + 0) ); sink.record( @@ -6027,7 +6027,7 @@ fn read_M< sink.record( modrm_start + 6, modrm_start + 7, - InnerDescription::Misc("mmm field is a simple register dereference (mod bits: 00)") + InnerDescription::Misc("memory operand is [reg] with no displacement, register selected by `mmm` (mod bits: 00)") .with_id(modrm_start + 0) ); OperandSpec::Deref @@ -7721,6 +7721,11 @@ fn read_operands< T: Reader<<Arch as yaxpeax_arch::Arch>::Address, <Arch as yaxpeax_arch::Arch>::Word>, S: DescriptionSink<FieldDescription> >(decoder: &InstDecoder, words: &mut T, instruction: &mut Instruction, operand_code: OperandCode, sink: &mut S) -> Result<(), DecodeError> { + sink.record( + words.offset() as u32 * 8 - 1, words.offset() as u32 * 8 - 1, + InnerDescription::Boundary("opcode ends/operands begin (typically)") + .with_id(words.offset() as u32 * 8 - 1) + ); let modrm_start = words.offset() as u32 * 8; let opcode_start = modrm_start - 8; instruction.operands[0] = OperandSpec::RegRRR; |